Use multipledispatch to define divide (plus dostring for add)

mapytex/calculus/core/compute/add.py

@@ -10,19 +10,19 @@
 Adding MO
 """
 
+from multipledispatch import Dispatcher
 from ..tree import Tree
 from ..MO.mo import MO, MOnumber
 from ..MO.fraction import MOFraction
 from .exceptions import AddError
 from .arithmetic import lcm
 from .type_filter import args_are
-from multipledispatch import Dispatcher
 
 add_doc = """ Adding MOs
 
-    :param left: left MO
-    :param right: right MO
-    :return: Tree or MO
+:param left: left MO
+:param right: right MO
+:return: Tree or MO
 
 """
 add = Dispatcher("add", doc=add_doc)

mapytex/calculus/core/compute/divide.py

@@ -10,51 +10,26 @@
 Divide MO
 """
 
+from multipledispatch import Dispatcher
 from ..tree import Tree
 from ..MO.mo import MO, MOnumber
 from ..MO.fraction import MOFraction
 from .exceptions import DivideError
 from .type_filter import args_are
 
+divide_doc = """ Dividing MOs
 
-def divide(left, right):
-    """ Perform the addition of left and right
+:param left: left MO
+:param right: right MO
+:returns: Tree or MO
 
-    :param left: left MO
-    :param right: right MO
-    :returns: Tree or MO
+"""
 
-    >>> a = MOnumber(4)
-    >>> b = MOnumber(6)
-    >>> divide(a, b)
-    <MOFraction 4 / 6>
-    >>> b = MOnumber(0)
-    >>> divide(a, b)
-    Traceback (most recent call last):
-        ...
-    mapytex.calculus.core.compute.exceptions.DivideError: Division by zero
+divide = Dispatcher("divide", doc=divide_doc)
 
-    """
-    try:
-        right.value
-    except AttributeError:
-        pass
-    else:
-        if right.value == 0:
-            raise DivideError("Division by zero")
-
-    if right.value == 1:
-        return left
-
-    return MULFUNCTIONS[(type(left), type(right))](left, right)
-
-@args_are(MOnumber, MOnumber)
+@divide.register(MOnumber, MOnumber)
 def monumber_monumber(left, right):
-    """ Divide 2 monumbers
-
-    :param left: left MOnumber
-    :param right: right MOnumber
-    :returns: MONumber
+    """ Divide 2 monumbers and return a MOFraction
 
     >>> a = MOnumber(4)
     >>> b = MOnumber(6)
@@ -63,13 +38,9 @@ def monumber_monumber(left, right):
     """
     return MOFraction(left, right)
 
-@args_are(MOnumber, MOFraction)
+@divide.register(MOnumber, MOFraction)
 def monumber_mofraction(left, right):
-    """ Divide a monumber and a mofraction
-
-    :param left: a monumber
-    :param right: a mofraction
-    :returns: Tree with the multiplication on the numerator
+    """ Divide a monumber and a mofraction by inverting MOFraction
 
     >>> a = MOnumber(4)
     >>> b = MOFraction(6, 5)
@@ -89,19 +60,11 @@ def monumber_mofraction(left, right):
      | | > 5
      | | > 6
     """
-    if not isinstance(left, MOnumber) or not isinstance(right, MOFraction):
-        raise DivideError(f"Wrong type for left (got {left.__class__.__name__}) \
-                or right (got {right.__class__.__name__})")
-
     return Tree("*", left, right.inverse())
 
-@args_are(MOFraction, MOnumber)
+@divide.register(MOFraction, MOnumber)
 def mofraction_monumber(left, right):
-    """ Divide a monumber and a mofraction
-
-    :param left: a mofraction
-    :param right: a monumber
-    :returns: Tree with a new calculus
+    """ Divide a monumber and a mofraction by inverting MOnumber
 
     >>> a = MOFraction(6, 5)
     >>> b = MOnumber(4)
@@ -115,20 +78,12 @@ def mofraction_monumber(left, right):
      | > 4
     """
 
-    if not isinstance(left, MOFraction) or not isinstance(right, MOnumber):
-        raise DivideError(f"Wrong type for left (got {left.__class__.__name__})"
-                          f"or right (got {right.__class__.__name__})")
-
     right_fraction = MOFraction(1, right)
     return Tree("*", left, right_fraction)
 
-@args_are(MOFraction, MOFraction)
+@divide.register(MOFraction, MOFraction)
 def mofraction_mofraction(left, right):
-    """ Divide two mofractions
-
-    :param left: a mofraction
-    :param right: a mofraction
-    :returns: Tree with a new calculus
+    """ Divide two mofractions by inverting right MOFraction
 
     >>> a = MOFraction(1, 5)
     >>> b = MOFraction(4, 5)
@@ -142,20 +97,38 @@ def mofraction_mofraction(left, right):
      | > 4
 
     """
-
-    if not isinstance(left, MOFraction) or not isinstance(right, MOFraction):
-        raise AddError(f"Wrong type for left (got {left.__class__.__name__})"
-                f"or right (got {right.__class__.__name__})")
-
     return Tree("*", left, right.inverse())
 
-# TODO: Faire un décorateur pour un enregistrement automatique |dim. mars 11 18:24:32 EAT 2018
-MULFUNCTIONS = {
-    (MOnumber, MOnumber): monumber_monumber,
-    (MOnumber, MOFraction): monumber_mofraction,
-    (MOFraction, MOnumber): mofraction_monumber,
-    (MOFraction, MOFraction): mofraction_mofraction,
-    }
+#def divide(left, right):
+#    """ Perform the addition of left and right
+#
+#    :param left: left MO
+#    :param right: right MO
+#    :returns: Tree or MO
+#
+#    >>> a = MOnumber(4)
+#    >>> b = MOnumber(6)
+#    >>> divide(a, b)
+#    <MOFraction 4 / 6>
+#    >>> b = MOnumber(0)
+#    >>> divide(a, b)
+#    Traceback (most recent call last):
+#        ...
+#    mapytex.calculus.core.compute.exceptions.DivideError: Division by zero
+#
+#    """
+#    try:
+#        right.value
+#    except AttributeError:
+#        pass
+#    else:
+#        if right.value == 0:
+#            raise DivideError("Division by zero")
+#
+#    if right.value == 1:
+#        return left
+#
+#    return MULFUNCTIONS[(type(left), type(right))](left, right)
 
 # -----------------------------
 # Reglages pour 'vim'