clean: clean python code
This commit is contained in:
19
app.py
19
app.py
@@ -1,7 +1,7 @@
|
||||
import os
|
||||
import logging
|
||||
from flask import Flask, render_template
|
||||
from models import db, Assessment, Student, ClassGroup
|
||||
from models import db, ClassGroup
|
||||
from repositories import AssessmentRepository, StudentRepository
|
||||
from commands import init_db, create_large_test_data
|
||||
from app_config_classes import config
|
||||
from app_config import config_manager
|
||||
@@ -52,9 +52,12 @@ def create_app(config_name=None):
|
||||
@app.route('/')
|
||||
def index():
|
||||
try:
|
||||
recent_assessments = Assessment.query.order_by(Assessment.date.desc()).limit(5).all()
|
||||
total_students = Student.query.count()
|
||||
total_assessments = Assessment.query.count()
|
||||
assessment_repo = AssessmentRepository()
|
||||
student_repo = StudentRepository()
|
||||
|
||||
recent_assessments = assessment_repo.find_recent(5)
|
||||
total_students = student_repo.model_class.query.count() # Keeping simple count
|
||||
total_assessments = assessment_repo.model_class.query.count() # Keeping simple count
|
||||
total_classes = ClassGroup.query.count()
|
||||
return render_template('index.html',
|
||||
recent_assessments=recent_assessments,
|
||||
@@ -78,10 +81,8 @@ def create_app(config_name=None):
|
||||
def students():
|
||||
try:
|
||||
# Optimisation: utiliser joinedload pour éviter les requêtes N+1
|
||||
from sqlalchemy.orm import joinedload
|
||||
students = Student.query.options(joinedload(Student.class_group)).order_by(
|
||||
ClassGroup.name, Student.last_name, Student.first_name
|
||||
).join(ClassGroup).all()
|
||||
student_repo = StudentRepository()
|
||||
students = student_repo.find_all_with_class_ordered()
|
||||
return render_template('students.html', students=students)
|
||||
except Exception as e:
|
||||
app.logger.error(f'Erreur lors du chargement des étudiants: {e}')
|
||||
|
||||
Reference in New Issue
Block a user