From 4e13d0e32f8b14a4bf135800a35cd982f1ebef68 Mon Sep 17 00:00:00 2001
From: Bertrand Benjamin <benjamin.bertrand@opytex.org>
Date: Tue, 27 Dec 2022 08:13:34 +0100
Subject: [PATCH] Feat: rename populate and use fakers

---
 backend/model/tribe.py                        |  3 +
 ...ite.py => test_repository_tribe_sqlite.py} | 56 +++++++++----------
 2 files changed, 28 insertions(+), 31 deletions(-)
 rename tests/integration/{test_repository_sqlite.py => test_repository_tribe_sqlite.py} (63%)

diff --git a/backend/model/tribe.py b/backend/model/tribe.py
index e6ff677..5833d1d 100644
--- a/backend/model/tribe.py
+++ b/backend/model/tribe.py
@@ -28,3 +28,6 @@ class Tribe:
 
     def to_dict(self) -> dict:
         return {"name": self.name, "level": self.level}
+
+    def to_tuple(self) -> tuple:
+        return (self.name, self.level)
diff --git a/tests/integration/test_repository_sqlite.py b/tests/integration/test_repository_tribe_sqlite.py
similarity index 63%
rename from tests/integration/test_repository_sqlite.py
rename to tests/integration/test_repository_tribe_sqlite.py
index 4455ec2..6c9a7a3 100644
--- a/tests/integration/test_repository_sqlite.py
+++ b/tests/integration/test_repository_tribe_sqlite.py
@@ -5,39 +5,38 @@ import pytest
 from backend.adapters.sqlite import create_db
 from backend.model.tribe import Tribe
 from backend.repository.tribe_sqlite_repository import TribeSQLiteRepository
+from tests.model.fakes import build_tribes
 
 
-def populate_tribe(conn) -> list[Tribe]:
+def populate_tribes(conn) -> list[Tribe]:
     cursor = conn.cursor()
-    tribes = [
-        ("Tribe1", "2nd"),
-        ("Tribe2", "2nd"),
-        ("Tribe3", "1ST"),
-    ]
+    tribes = build_tribes(3)
     cursor.executemany(
         """
         INSERT INTO tribes(name, level) VALUES (?, ?)
     """,
-        tribes,
+        [t.to_tuple() for t in tribes],
     )
     conn.commit()
 
-    return [Tribe(*t) for t in tribes]
+    return tribes
 
 
 def test_get_tribe(sqlite_conn):
     create_db(sqlite_conn)
-    prebuild_tribes = populate_tribe(sqlite_conn)
+    prebuild_tribes = populate_tribes(sqlite_conn)
+
+    name = prebuild_tribes[0].name
 
     tribe_repo = TribeSQLiteRepository(sqlite_conn)
-    tribes = tribe_repo.get("Tribe1")
+    tribes = tribe_repo.get(name)
 
     assert prebuild_tribes[0] == tribes
 
 
 def test_get_tribe_not_exists(sqlite_conn):
     create_db(sqlite_conn)
-    prebuild_tribes = populate_tribe(sqlite_conn)
+    prebuild_tribes = populate_tribes(sqlite_conn)
 
     tribe_repo = TribeSQLiteRepository(sqlite_conn)
     with pytest.raises(ValueError):
@@ -46,7 +45,7 @@ def test_get_tribe_not_exists(sqlite_conn):
 
 def test_list_tribes(sqlite_conn):
     create_db(sqlite_conn)
-    prebuild_tribes = populate_tribe(sqlite_conn)
+    prebuild_tribes = populate_tribes(sqlite_conn)
 
     tribe_repo = TribeSQLiteRepository(sqlite_conn)
     tribes = tribe_repo.list()
@@ -78,42 +77,37 @@ def test_add_tribe(sqlite_conn):
 
 def test_add_tribe_fail_exists(sqlite_conn):
     create_db(sqlite_conn)
-    prebuild_tribes = populate_tribe(sqlite_conn)
+    prebuild_tribes = populate_tribes(sqlite_conn)
 
     tribe_repo = TribeSQLiteRepository(sqlite_conn)
 
-    tribe_infos = ("Tribe1", "2nd")
-    tribe = Tribe(*tribe_infos)
+    existing_tribe = prebuild_tribes[0]
     with pytest.raises(sqlite3.IntegrityError):
-        tribe_repo.add(tribe)
+        tribe_repo.add(existing_tribe)
 
 
 def test_update_tribe(sqlite_conn):
     create_db(sqlite_conn)
-    prebuild_tribes = populate_tribe(sqlite_conn)
+    prebuild_tribes = populate_tribes(sqlite_conn)
 
     tribe_repo = TribeSQLiteRepository(sqlite_conn)
-    tribe_repo.update("Tribe1", Tribe("Tribe0", "Term"))
+
+    name = prebuild_tribes[0].name
+    new_tribe = Tribe("Tribe0", "Term")
+    tribe_repo.update(name, new_tribe)
     sqlite_conn.commit()
 
-    expected = [
-        Tribe("Tribe0", "Term"),
-        Tribe("Tribe2", "2nd"),
-        Tribe("Tribe3", "1ST"),
-    ]
-    assert tribe_repo.list() == expected
+    prebuild_tribes[0] = new_tribe
+    assert tribe_repo.list() == prebuild_tribes
 
 
 def test_delete_tribe(sqlite_conn):
     create_db(sqlite_conn)
-    prebuild_tribes = populate_tribe(sqlite_conn)
+    prebuild_tribes = populate_tribes(sqlite_conn)
 
     tribe_repo = TribeSQLiteRepository(sqlite_conn)
-    tribe_repo.delete(prebuild_tribes[0])
+    deleted_tribe = prebuild_tribes.pop()
+    tribe_repo.delete(deleted_tribe)
     sqlite_conn.commit()
 
-    expected = [
-        Tribe("Tribe2", "2nd"),
-        Tribe("Tribe3", "1ST"),
-    ]
-    assert tribe_repo.list() == expected
+    assert tribe_repo.list() == prebuild_tribes