Feat: add put for student and fix fixture around database

This commit is contained in:
2022-12-29 17:47:40 +01:00
parent c541d0063f
commit 5cf062c7a0
8 changed files with 94 additions and 87 deletions

View File

@@ -4,7 +4,10 @@ import pytest
from backend.model.student import Student
from backend.model.tribe import Tribe
from backend.repository.student_sqlite_repository import StudentSQLiteRepository
from backend.repository.student_sqlite_repository import (
StudentRepositoryError,
StudentSQLiteRepository,
)
from tests.integration.test_repository_tribe_sqlite import populate_tribes
from tests.model.fakes import build_student
@@ -100,7 +103,7 @@ def test_update_student(sqlite_conn):
student.name = "Boby"
student.tribe = prebuild_tribes[-1]
student_repo.update(student.id, student)
student_repo.update(student)
sqlite_conn.commit()
student_list = student_repo.list(prebuild_tribes)
@@ -110,6 +113,17 @@ def test_update_student(sqlite_conn):
assert moded_student == student
def test_update_student_does_not_exists(sqlite_conn):
prebuild_tribes = populate_tribes(sqlite_conn)
student_repo = StudentSQLiteRepository(sqlite_conn)
student = Student(name="jkl", tribe=prebuild_tribes[0])
with pytest.raises(StudentRepositoryError):
student_repo.update(student)
def test_delete_student(sqlite_conn):
prebuild_tribes = populate_tribes(sqlite_conn)
prebuild_students = populate_students(sqlite_conn, prebuild_tribes)

View File

@@ -1,73 +0,0 @@
from backend.model.tribe import Tribe
from backend.repository.tribe_sqlalchemy_repository import TribeSQLAlchemyRepository
def test_add_tribe(session):
tribe_infos = ("tribe1", "2nd")
tribe = Tribe(*tribe_infos)
tribe_repo = TribeSQLAlchemyRepository(session)
tribe_repo.add(tribe)
session.commit()
rows = list(session.execute("SELECT name, level FROM 'tribes'"))
assert rows == [tribe_infos]
def test_list_tribes(session):
session.execute(
"INSERT INTO tribes (name, level) VALUES "
"('tribe1', '2nd'),"
"('tribe2', '1ST')"
)
expected = [
(Tribe("tribe1", "2nd")),
(Tribe("tribe2", "1ST")),
]
tribe_repo = TribeSQLAlchemyRepository(session)
assert tribe_repo.list() == expected
def test_update_tribe(session):
session.execute(
"INSERT INTO tribes (name, level) VALUES "
"('tribe1', '2nd'),"
"('tribe2', '1ST')"
)
tribe_repo = TribeSQLAlchemyRepository(session)
tribe_repo.update("tribe1", Tribe("tribe3", "Term"))
session.commit()
expected = [
(Tribe("tribe3", "Term")),
(Tribe("tribe2", "1ST")),
]
assert tribe_repo.list() == expected
def test_get_tribes(session):
session.execute(
"INSERT INTO tribes (name, level) VALUES "
"('tribe1', '2nd'),"
"('tribe2', '1ST')"
)
expected = Tribe("tribe1", "2nd")
tribe_repo = TribeSQLAlchemyRepository(session)
assert tribe_repo.get("tribe1") == expected
def test_delete_tribes(session):
session.execute(
"INSERT INTO tribes (name, level) VALUES "
"('tribe1', '2nd'),"
"('tribe2', '1ST')"
)
expected = [
(Tribe("tribe2", "1ST")),
]
tribe_repo = TribeSQLAlchemyRepository(session)
tribe_repo.delete(Tribe("tribe1", "2nd"))
session.commit()
assert tribe_repo.list() == expected

View File

@@ -3,7 +3,10 @@ import sqlite3
import pytest
from backend.model.tribe import Tribe
from backend.repository.tribe_sqlite_repository import TribeSQLiteRepository
from backend.repository.tribe_sqlite_repository import (
TribeRepositoryError,
TribeSQLiteRepository,
)
from tests.model.fakes import build_tribes
@@ -36,7 +39,7 @@ def test_get_tribe_not_exists(sqlite_conn):
prebuild_tribes = populate_tribes(sqlite_conn)
tribe_repo = TribeSQLiteRepository(sqlite_conn)
with pytest.raises(ValueError):
with pytest.raises(TribeRepositoryError):
tribe_repo.get("Tribe0")
@@ -50,7 +53,6 @@ def test_list_tribes(sqlite_conn):
def test_add_tribe(sqlite_conn):
tribe_repo = TribeSQLiteRepository(sqlite_conn)
tribe_infos = ("tribe1", "2nd")
@@ -76,7 +78,7 @@ def test_add_tribe_fail_exists(sqlite_conn):
tribe_repo = TribeSQLiteRepository(sqlite_conn)
existing_tribe = prebuild_tribes[0]
with pytest.raises(sqlite3.IntegrityError):
with pytest.raises(TribeRepositoryError):
tribe_repo.add(existing_tribe)